-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scheduler: fix false add_condition replace warning #3107
Merged
kmantel
merged 1 commit into
PrincetonUniversity:devel
from
kmantel:scheduler-cond-warning
Nov 12, 2024
Merged
Scheduler: fix false add_condition replace warning #3107
kmantel
merged 1 commit into
PrincetonUniversity:devel
from
kmantel:scheduler-cond-warning
Nov 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR causes the following changes to the html docs (ubuntu-latest-3.11):
See CI logs for the full diff. |
kmantel
force-pushed
the
scheduler-cond-warning
branch
from
November 9, 2024 06:40
59360fe
to
01ef33d
Compare
This PR causes the following changes to the html docs (ubuntu-latest-3.11):
See CI logs for the full diff. |
Do not set _user_specified_conds in __init__, because it will be set by add_condition_set in graph_scheduler.Scheduler.__init__. This second call would result in the condition replacement warning for any conditions passed in.
kmantel
force-pushed
the
scheduler-cond-warning
branch
from
November 12, 2024 00:48
01ef33d
to
87c0e88
Compare
This PR causes the following changes to the html docs (ubuntu-latest-3.11):
See CI logs for the full diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not set _user_specified_conds in init,
because it will be set by add_condition_set
in graph_scheduler.Scheduler.init. This second call would result in the condition replacement warning for any conditions passed in.